Skip to content

Fix for Message Duplication Error #74 - #79

Open
dustinbrisebois wants to merge 1 commit into
lsuonline:masterfrom
dustinbrisebois:patch-1
Open

Fix for Message Duplication Error #74#79
dustinbrisebois wants to merge 1 commit into
lsuonline:masterfrom
dustinbrisebois:patch-1

Conversation

@dustinbrisebois

Copy link
Copy Markdown

#74

Changing the call from $original to $new fixes the duplication error

lsuonline#74

Changing the call from $original to $new fixes the duplication error
@Syxton

Syxton commented Jan 16, 2024

Copy link
Copy Markdown
Contributor

@dustinbrisebois I believe this change is incorrect. The real issue stems from classes/messenger/messenger.php on around line 473 & 474. The lines reference the wrong variable name.

    // Duplicate files.
    message_file_handler::duplicate_files($originaldraft, $newdraft, 'attachments');
    message_file_handler::duplicate_files($originaldraft, $newdraft, 'message_editor');

SHOULD BE

    // Duplicate files.
    message_file_handler::duplicate_files($originalmessage, $newdraft, 'attachments');
    message_file_handler::duplicate_files($originalmessage, $newdraft, 'message_editor');

I have pushed another request, this can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants