Link to broadcast page when courseid == siteid on qm.php (#130) - #131
Open
djarran wants to merge 1 commit into
Open
Link to broadcast page when courseid == siteid on qm.php (#130)#131djarran wants to merge 1 commit into
djarran wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: Resolves #130. This PR aligns the block content and
qm.phpso that the "Compose message" links tobroadcast.phpwhen on the site course (ID = 1).Testing steps:
Test existing block functionality
course/view.php?id=1QuickmailblockCompose messagebutton links tobroadcast.phpQuickmailblockCompose messagebutton links tocompose.phpTest that
qm.phpnow has same behaviour as block functionality regarding "Compose message" buttonblocks/quickmail/qm.php?courseid=1Compose messagebutton links tobroadcast.phpblocks/quickmail/qm.php?courseid={courseid}Compose messagebutton now links tocompose.php