Repository navigation
Conversation
BrunoSanchez
self-requested a review
November 3, 2026 07:38
BrunoSanchez
approved these changes
Nov 3, 2026
BrunoSanchez
left a comment
BrunoSanchez
left a comment
Member
There was a problem hiding this comment.
I think it looks good.
I was able to follow the code, however a discussion could help me understand some of the details on the polygons, and on the template info stored in the diaSources metadata.
| inputBounds = Box.from_legacy(record.getBBox()) if polygon is None else Polygon.from_legacy(polygon) | ||
| inputToCoadd = _pixelTransform(record.getWcs(), coaddWcs) | ||
| try: | ||
| footprint = ( |
Member
There was a problem hiding this comment.
Can you explain this line? I am not sure I follow exactly how it is chaining the transforms and intersections.
BrunoSanchez
reviewed
Nov 3, 2026
Comment on lines
+113
to
+123
| record : `lsst.afw.table.ExposureRecord` | ||
| Input record of a coadd, with the input's WCS, bounding box and | ||
| optional valid polygon. | ||
| coaddWcs : `lsst.afw.geom.SkyWcs` | ||
| WCS of the coadd. | ||
| scienceInCoadd : `lsst.images.Polygon` | ||
| ``scienceBox`` in coadd pixels. | ||
| coaddToScience : `lsst.images.Transform` | ||
| Transform from coadd pixels to science image pixels. | ||
| scienceBox : `lsst.images.Box` | ||
| Bounding box of the science image. |
Member
There was a problem hiding this comment.
Maybe add a few words here to clarify that the "coaddWcs" and input wcs are different, as the coaddWcs and all related to coadd is defined in the skymap of choice.
It is just to clarify to the user that the transformation here needed is not only inputs to science and its inverse, but also to the "coadd" sky coordinates
Each input's overlap with the science image is found in coadd pixels, so no detector WCS is evaluated far outside its own image. The border of each coadd input's bbox is trimmed to account for the size of the warping kernel.
isullivan
force-pushed
the
tickets/DM-56879
branch
from
November 4, 2026 00:37
abb9bcf to
b4d4e7a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.