DM-55493: drop split-on-trailing-comma redundant with ruff-shared.toml - #359
Merged
Conversation
…toml ruff-shared.toml already sets [lint.isort] split-on-trailing-comma = false, so the pyproject copy is dead config. Clears the toml-not-redundant check of the ruff-shared-config migration. This was meant to ride along with #356 but that PR merged ~1 minute before the change was pushed, so the commit landed on an already-merged branch.
jonathansick
enabled auto-merge
July 27, 2026 20:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ruff-shared.tomlalready sets[lint.isort] split-on-trailing-comma = false, so the copy inpyproject.tomlis dead config — removing it is behaviourally inert.This clears the
toml-not-redundantcheck of theruff-shared-configmigration, which is the last thing keeping documenteer non-compliant after the ruff 0.16.0 CPY001 refresh (#353) and the Sphinx role scoping (#356).Why this is a separate PR: it was meant to ride along with #356, but that PR merged about a minute before this change was pushed, so the commit landed on an already-merged branch and never reached main.
Validation
ruff 0.16.0 check .— All checks passedruff 0.16.0 format --check .— 139 files already formattedRef: DM-55493