Skip to content

DM-55493: drop split-on-trailing-comma redundant with ruff-shared.toml - #359

Merged
jonathansick merged 1 commit into
mainfrom
tickets/DM-55493-isort-prune
Jul 27, 2026
Merged

DM-55493: drop split-on-trailing-comma redundant with ruff-shared.toml#359
jonathansick merged 1 commit into
mainfrom
tickets/DM-55493-isort-prune

Conversation

@jonathansick

Copy link
Copy Markdown
Member

ruff-shared.toml already sets [lint.isort] split-on-trailing-comma = false, so the copy in pyproject.toml is dead config — removing it is behaviourally inert.

This clears the toml-not-redundant check of the ruff-shared-config migration, which is the last thing keeping documenteer non-compliant after the ruff 0.16.0 CPY001 refresh (#353) and the Sphinx role scoping (#356).

Why this is a separate PR: it was meant to ride along with #356, but that PR merged about a minute before this change was pushed, so the commit landed on an already-merged branch and never reached main.

Validation

  • ruff 0.16.0 check . — All checks passed
  • ruff 0.16.0 format --check . — 139 files already formatted
  • Diff is a single deletion; no behaviour change, since the inherited value is identical.

Ref: DM-55493

…toml

ruff-shared.toml already sets [lint.isort] split-on-trailing-comma = false,
so the pyproject copy is dead config. Clears the toml-not-redundant check of
the ruff-shared-config migration.

This was meant to ride along with #356 but that PR merged ~1 minute before
the change was pushed, so the commit landed on an already-merged branch.
@jonathansick
jonathansick enabled auto-merge July 27, 2026 20:31
@jonathansick
jonathansick merged commit 01efe2a into main Jul 27, 2026
12 checks passed
@jonathansick
jonathansick deleted the tickets/DM-55493-isort-prune branch July 27, 2026 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant