Staging into Main - fix charts display

[rsmoke]

This pull request focuses on improving the management of Chart.js instances for questionnaire response charts, especially in the context of Turbo navigation, to prevent memory leaks and ensure charts are properly initialized and destroyed. Additionally, there is a minor optimization in the loading of faculty associations in the student calendar controller.

Chart.js instance management and Turbo navigation improvements:

• Added global event listeners in app/javascript/application.js to destroy all questionnaireCharts Chart.js instances before Turbo navigates away, and to re-initialize charts on page load or Turbo load, preventing memory leaks and duplicate charts.
• Refactored the chart initialization logic in app/views/questionnaires/responses.html.erb to:
  • Use a global window.questionnaireCharts array to track chart instances.
  • Destroy existing charts before creating new ones, both on initial load and when revisiting via Turbo.
  • Store newly created chart instances in the global array for easy cleanup.

Student calendar controller optimization:

• Updated .includes in app/controllers/student/calendar_controller.rb to preload the :participating_faculty association along with calendar_event_faculties: :vip, reducing N+1 queries and improving performance.

[Copilot]

Pull request overview

This PR aims to fix Questionnaire response charts (Chart.js) under Turbo navigation by tracking/destroying chart instances across visits, and also reduces N+1 queries in the student calendar by preloading faculty associations.

Changes:

• Added global Turbo lifecycle handlers to destroy and (re)initialize questionnaire charts across Turbo navigations.
• Refactored questionnaire responses view JS to track Chart.js instances in a global array and destroy existing instances before recreating.
• Optimized student calendar event loading by preloading :participating_faculty.

Reviewed changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.

File	Description
app/views/questionnaires/responses.html.erb	Defines initQuestionnaireCharts() and tracks/destroys per-question Chart.js instances via window.questionnaireCharts.
app/javascript/application.js	Adds Turbo event listeners to destroy charts on navigation and call initQuestionnaireCharts() on load events.
app/controllers/student/calendar_controller.rb	Expands .includes to preload :participating_faculty to reduce N+1s.
Gemfile.lock	Updates various gem versions as part of the staging-to-main merge.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Using turbo:before-render to tear down Chart.js instances may be too late for Turbo’s page snapshot caching; the recommended hook for cleanup is turbo:before-cache so the cached DOM doesn’t retain canvas/chart state and Chart instances don’t linger in memory. Consider moving (or duplicating) this teardown to turbo:before-cache (and keeping before-render only if you have a specific need for it).

Suggested change

	// Also destroy questionnaire Chart.js instances before Turbo caches the page snapshot
	document.addEventListener("turbo:before-cache", function () {
	if (window.questionnaireCharts && Array.isArray(window.questionnaireCharts)) {
	window.questionnaireCharts.forEach(function (chart) {
	try {
	if (chart && typeof chart.destroy === "function") chart.destroy();
	} catch (e) {
	console.warn("Questionnaire chart destroy:", e);
	}
	});
	window.questionnaireCharts = [];
	}
	});