Skip to content

⚡ refactor: optimize isPrime using standard for loop #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lourenzo wants to merge 1 commit into
base: main
Choose a base branch
from
Open

⚡ refactor: optimize isPrime using standard for loop #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/PrimeToolKit.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,12 @@ public class PrimeToolKit {

// From exercise 003
static boolean isPrime(long number) {
return number > 1 && range(2, Math.round(Math.sqrt(number))).noneMatch(i -> number % i == 0);
if (number <= 1) return false;
long limit = Math.round(Math.sqrt(number));
for (long i = 2; i <= limit; i++) {
if (number % i == 0) return false;
}
return true;
}

// From exercise 007
Expand Down