Skip to content

Problem with windows username that sometimes end in $ #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zparta wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Problem with windows username that sometimes end in $ #3

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cf0bbcc
Problem with $ in username on some Windows users
zparta Apr 10, 2026
262109f
Fix syntax in getRevInfo.sh for builder variable
zparta Apr 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Ar/RevInfo/getRevInfo.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ VAR CONSTANT
uncommittedChanges : STRING[80] := '$(git diff --shortstat)';
buildDate : STRING[80] := '$(date +"%Y-%m-%d %H:%M:%S %z")';
buildConfiguration : STRING[80] := '${AS_CONFIGURATION}';
builder : STRING[80] := '${AS_USER_NAME}';
builder : STRING[80] := '$(echo "${AS_USER_NAME}" | sed 's/\$//g')';

Copilot AI Apr 14, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The quoting in this line is broken: the outer single-quoted string for the .var value is terminated by the inner sed 's/\$//g', which will cause a shell syntax error and/or generate an invalid RevInfo.var. Use a quoting-safe approach (e.g., shell parameter expansion like ${AS_USER_NAME%\$} to strip a trailing $, or keep sed but quote it with double-quotes and escape $). Also consider stripping only a trailing $ rather than removing all $ characters.

Suggested change
builder : STRING[80] := '$(echo "${AS_USER_NAME}" | sed 's/\$//g')';
builder : STRING[80] := '${AS_USER_NAME%\$}';

Copilot uses AI. Check for mistakes.
END_VAR
EOF

Expand Down