Fix/provenance repository - #32
Merged
Merged
Conversation
lectio-docs was missing `repository`, so OIDC publishing failed provenance validation — npm checks package.json repository.url against the sigstore attestation from GitHub Actions. Matches the core packages' metadata. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This change prevents blank page rendering when running `lectio dev` via npx or similar installations. The dev server now accommodates symlinked dependencies, ensuring React Router's client entry loads correctly.
There was a problem hiding this comment.
Pull request overview
This PR updates the site-builder package metadata and adjusts Vite dev-server filesystem settings so lectio dev works reliably when installed via npx/external stores where dependencies resolve outside the materialized site directory.
Changes:
- Loosens Vite dev-server filesystem restrictions to allow reading symlinked dependencies outside the site dir.
- Adds
repositorymetadata toapps/site-builder/package.jsonfor correct package provenance. - Adds a changeset documenting the dev-server fix as a patch release.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| apps/site-builder/vite.config.ts | Adjusts Vite dev-server FS settings to load symlinked deps when run from materialized dirs (e.g., npx). |
| apps/site-builder/package.json | Adds repository metadata for npm provenance and monorepo directory linkage. |
| .changeset/dev-vite-fs-allow.md | Records a patch changeset describing the lectio dev blank-page fix. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+6
to
+11
| // The `lectio` CLI symlinks the site's dependencies in from wherever the | ||
| // package was installed (npx cache, pnpm store, …), whose realpaths sit | ||
| // outside the materialized site dir. Let the dev server read them — otherwise | ||
| // React Router's default client entry can't load and the page renders blank. | ||
| // Dev-server only; the static build is unaffected. | ||
| server: { fs: { strict: false } }, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.