fix(cli): add repository field so provenance validates on publish - #28
Merged
Conversation
lectio-docs was missing `repository`, so OIDC publishing failed provenance validation — npm checks package.json repository.url against the sigstore attestation from GitHub Actions. Matches the core packages' metadata. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
This PR fixes npm provenance validation for the lectio-docs package published from apps/site-builder by adding a repository field to its package.json, aligning it with the existing monorepo packages’ metadata so the Sigstore/GitHub Actions provenance repository URL matches during publish.
Changes:
- Add
"repository"metadata (type,url, anddirectory) toapps/site-builder/package.jsonto satisfy npm provenance checks. - Align the
apps/site-builderpackage’s repository metadata format withpackages/lectio-docsandpackages/lectio-docs-react.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The OIDC publish now authenticates (the trusted-publisher workflow filename was
corrected to
release.yml), but 0.2.0 failed provenance validation:lectio-docs(apps/site-builder) was missing arepositoryfield. npm checks itagainst the sigstore attestation GitHub Actions generates. Added it to match the
core packages.
No changeset: 0.2.0 is already the version on
main(just not on npm). Mergingthis triggers the release workflow, which republishes 0.2.0 — now with
provenance validating.
After merge
lectio-docs@0.2.0with provenancenpm view lectio-docs version→ 0.2.0