fix: replace placeholder allowBuilds value for @swc/core - #3
Merged
Conversation
`'@swc/core': set this to true or false` was committed as an unresolved
placeholder. pnpm 11 treats a non-boolean allowBuilds value as undecided,
so `strictDepBuilds` fails a fresh install:
[ERR_PNPM_IGNORED_BUILDS] Ignored build scripts: @swc/core@1.15.46
An explicit boolean — either one — satisfies the check. `false` is correct
here: @swc/core is only a transitive dep (webpack, ts-node), its postinstall
merely probes for the native binding, and both CI and the Docker build run
`pnpm install --ignore-scripts`, so no build path in this repo runs it.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
🟢 Ready to approve
The change is a minimal, correct YAML fix that resolves the stated pnpm behavior without impacting runtime code paths.
This review doesn't count toward merge requirements. Sign up for the private preview to control whether Copilot approvals count.
Pull request overview
This PR fixes a pnpm-workspace.yaml configuration error where allowBuilds['@swc/core'] contained a non-boolean placeholder value, which causes pnpm strict dependency build checks to fail on fresh installs.
Changes:
- Replaced the placeholder
allowBuildsvalue for@swc/corewith an explicit boolean (false). - Ensures
pnpmno longer treats the entry as “undecided”, preventing install failures understrictDepBuilds.
File summaries
| File | Description |
|---|---|
| pnpm-workspace.yaml | Sets allowBuilds['@swc/core'] to a proper boolean to avoid pnpm strict build-check install failures. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
We're testing this review assessment. Please use 👍 or 👎 to tell us if it's correct.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
pnpm-workspace.yamlshipped an unresolved placeholder:pnpm 11 treats a non-boolean
allowBuildsvalue as undecided, sostrictDepBuildsfails a fresh install:Reproduced in an isolated test project — an explicit boolean, either one, satisfies the check.
Scope
CI (
historia-ci.yml) and the Docker build both runpnpm install --ignore-scripts, so the pipeline was never affected. This only broke a fresh localpnpm install.Why
false@swc/coreis only a transitive dep (via webpack and ts-node), its postinstall merely probes for the native binding, and no build path in this repo runs install scripts at all.Verification
pnpm install --frozen-lockfile— passespnpm --filter @eventuras/historia lint— 0 errorspnpm --filter '@eventuras/historia^...' build— passes🤖 Generated with Claude Code