Skip to content

feat: Widen logs dialog and simplify settings controls - #240

Open
dmarchevsky wants to merge 1 commit into
lordmathis:mainfrom
dmarchevsky:logs-dialog-improvements
Open

feat: Widen logs dialog and simplify settings controls#240
dmarchevsky wants to merge 1 commit into
lordmathis:mainfrom
dmarchevsky:logs-dialog-improvements

Conversation

@dmarchevsky

Copy link
Copy Markdown

Summary

  • Increases the logs dialog width for better readability.
  • Moves the manual refresh button and the Lines/Auto-refresh controls into the footer next to Copy/Download, and removes the Settings/Apply buttons since both controls already apply immediately on change.
  • Removes the redundant "Auto-refreshing every N seconds" indicator, which overlapped the footer controls.

Test plan

  • npm run type-check
  • npm run lint
  • npm test
  • Manually verified layout via headless Chromium screenshot

Increase the logs window width, move the manual refresh button and
Lines/Auto-refresh controls into the footer next to Copy/Download,
and drop the Settings/Apply buttons since both controls already
apply on change. Also removes the redundant "Auto-refreshing every
N seconds" indicator, which overlapped the footer controls.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@lordmathis

Copy link
Copy Markdown
Owner

Thanks for the PR! I like it. But there are a couple of things to address.

First, blocking, there's a bug. The old panel had an explicit Apply button. Now handleLineCountChange (LogDialog.tsx:126) sets state directly and the effect at LogDialog.tsx:75-79 has lineCount in its deps, so typing 500 fires 3 fetches (5 → 50 → 500). Out-of-order responses can leave stale logs shown. I'd suggest removing lineCount from the open-effect deps and fetching on blur/Enter (or debouncing)

Second, non-blocking (suggestion). Since this PR widens the dialog to 6xl, the log container's min-h-[400px] max-h-[500px] (LogDialog.tsx:192) now works against the max-h-[80vh] flex shell — the box gets stuck at 500px on tall screens while the dialog has room to spare, and on short viewports the min-height can overflow the shell. Could you drop the pair and use flex-1 min-h-0 instead? That lets the log area grow/shrink with the dialog itself, matching how ModelsDialog handles its content area.

@lordmathis lordmathis changed the title Widen logs dialog and simplify settings controls feat: Widen logs dialog and simplify settings controls Aug 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants