feat: Widen logs dialog and simplify settings controls - #240
Conversation
Increase the logs window width, move the manual refresh button and Lines/Auto-refresh controls into the footer next to Copy/Download, and drop the Settings/Apply buttons since both controls already apply on change. Also removes the redundant "Auto-refreshing every N seconds" indicator, which overlapped the footer controls. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
Thanks for the PR! I like it. But there are a couple of things to address. First, blocking, there's a bug. The old panel had an explicit Apply button. Now handleLineCountChange (LogDialog.tsx:126) sets state directly and the effect at LogDialog.tsx:75-79 has lineCount in its deps, so typing 500 fires 3 fetches (5 → 50 → 500). Out-of-order responses can leave stale logs shown. I'd suggest removing lineCount from the open-effect deps and fetching on blur/Enter (or debouncing) Second, non-blocking (suggestion). Since this PR widens the dialog to 6xl, the log container's min-h-[400px] max-h-[500px] (LogDialog.tsx:192) now works against the max-h-[80vh] flex shell — the box gets stuck at 500px on tall screens while the dialog has room to spare, and on short viewports the min-height can overflow the shell. Could you drop the pair and use flex-1 min-h-0 instead? That lets the log area grow/shrink with the dialog itself, matching how ModelsDialog handles its content area. |
Summary
Test plan
npm run type-checknpm run lintnpm test