docs: scope the page+hook rule to data/list pages - #131
Conversation
Auth form pages (Login/Register/ForgotPassword/ResetPassword) call the gRPC client directly from their react-hook-form submit handler instead of going through a dedicated hook. That's a second, already-consistent pattern for one-shot form submissions, not drift from the page+hook rule — clarify the rule's scope so it isn't mistaken for something to "fix" later. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Hnoh6YfJwp63szeP8ZFqVg
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe frontend guidance now distinguishes list/state pages that use a page-plus-hook pattern from simple form pages that may submit one gRPC call directly. ChangesFrontend guidance
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This updates frontend documentation to clarify when direct form submissions are appropriate, without changing application behavior or runtime dependencies. Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Code Review ✅ ApprovedClarifies that the page+hook rule in OptionsAuto-apply is off → Gitar will not commit updates to this branch. Comment with these commands to change the behavior for this request:
Was this helpful? React with 👍 / 👎 | Powered by Gitar — free for open source |
|



Summary
useXxxhook rule inCLAUDE.mdis scoped to data/list pages (loading/error/empty/data states), not every pageLoginPage,RegisterPage,ForgotPasswordPage,ResetPasswordPage) already use a second, consistent pattern — a one-shot gRPC call directly in thereact-hook-formsubmit handler — so this isn't drift to "fix"Related issue
Found while reviewing this cycle's
architectrefactor-analysis output: those four pages callauthClient.*directly, which reads as a page+hook rule violation on a literal reading ofCLAUDE.md. Investigation showed it's a deliberate, internally consistent second pattern (a dedicated hook for one gRPC call in a form submit handler would be pure ceremony), not something to refactor. Documenting the scope prevents a future pass from "fixing" four working pages for no benefit.Type of change
Checklist
dotnet build --configuration Releasepasses with 0 errors (unaffected by this change)cd src/pressmark-web && npm run buildpasses with 0 TypeScript errors (unaffected by this change)t('ns:key')— no strings touchedNotes for reviewers
Doc-only change, no code touched. Part of the bi-weekly
/maintaincycle (2026-09-04/05).🤖 Generated with Claude Code
https://claude.ai/code/session_01Hnoh6YfJwp63szeP8ZFqVg
Generated by Claude Code
Summary by CodeRabbit