fix: install llvm-tools-preview in llvm-cov-install recipe#448
Merged
Conversation
The llvm-profdata binary was missing under the vx-managed Rust toolchain because the llvm-tools-preview component was not installed. cargo-llvm-cov requires this component to merge profile data and generate coverage reports. Add vx rustup component add llvm-tools-preview to the llvm-cov-install recipe so it runs before each coverage job.
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project check has failed because the head coverage (49.12%) is below the target coverage (70.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #448 +/- ##
==========================================
+ Coverage 49.11% 49.12% +0.01%
==========================================
Files 119 119
Lines 13388 13389 +1
Branches 24 24
==========================================
+ Hits 6576 6578 +2
+ Misses 6812 6811 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
Contributor
📸 Gallery E2E ScreenshotsScreenshots from this PR's E2E tests. View all artifacts
ℹ️ How to view screenshots
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
llvm-profdatamissing under vx-managed Rust toolchain in CIvx rustup component add llvm-tools-previewto thellvm-cov-installrecipe so it runs before each coverage jobcargo-llvm-covrequiresllvm-profdatafrom thellvm-tools-previewcomponent to merge profile dataRoot Cause
The
llvm-tools-previewRust component was never installed for the vx-managed toolchain. Theci-rust-coverage-lcovrecipe's prerequisitellvm-cov-installonly installedcargo-llvm-covitself. Whenvx cargo llvm-cov report --lcovtried to merge profile data, it looked forllvm-profdataat:which did not exist because
llvm-tools-previewwas missing.vx rustup component addis idempotent — it's a no-op when already installed.Test Plan
Rust Tests & Coveragejob passes on this PRrust-coverage.lcovartifact is generated