fix(ci): symlink system llvm-profdata into vx toolchain for rust coverage#440
Merged
Conversation
…rage vx rustup component add llvm-tools-preview reports the component as installed, but the llvm-profdata binary is missing at the expected path in the vx-managed Rust toolchain (~/.vx/store/rust/...). This causes cargo-llvm-cov report to fail with "could not execute process ... llvm-profdata merge (never executed): No such file or directory". Add a fixup step that detects the missing binary and creates a symlink from the system-installed dtolnay toolchain, which has llvm-tools properly installed.
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project check has failed because the head coverage (47.97%) is below the target coverage (70.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #440 +/- ##
==========================================
- Coverage 48.00% 47.97% -0.04%
==========================================
Files 118 118
Lines 13070 13070
Branches 24 24
==========================================
- Hits 6274 6270 -4
- Misses 6796 6800 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
Contributor
📸 Gallery E2E ScreenshotsScreenshots from this PR's E2E tests. View all artifacts
ℹ️ How to view screenshots
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
vx rustup component add llvm-tools-previewreports the component as installed, but thellvm-profdatabinary is actually missing at the expected path in the vx-managed Rust toolchaincargo-llvm-cov reportto fail withcould not execute process ... llvm-profdata merge (never executed): No such file or directoryFix
Added a fixup step after the vx llvm-tools-preview installation that:
llvm-profdataexists at the expected vx toolchain pathThe symlink approach is chosen over environment variables because cargo-llvm-cov determines the llvm tools path from the sysroot of the currently active
rustc, and the vx-managed rustc always points to the vx store path.Test plan
Rust Tests & Coveragepasses