fix(ci): install llvm-tools-preview through vx for rust coverage#439
Merged
Conversation
The dtolnay/rust-toolchain installs llvm-tools-preview to the system Rust toolchain, but vx cargo llvm-cov uses the vx-managed Rust store (~/.vx/store/rust/...) which lacks these tools. Add an explicit step to install llvm-tools-preview through vx after vx setup, ensuring the vx-managed toolchain has the required llvm-profdata binary. Fixes dependabot PR CI failures.
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project check has failed because the head coverage (48.00%) is below the target coverage (70.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #439 +/- ##
=======================================
Coverage 48.00% 48.00%
=======================================
Files 118 118
Lines 13070 13070
Branches 24 24
=======================================
Hits 6274 6274
Misses 6796 6796
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
Contributor
📸 Gallery E2E ScreenshotsScreenshots from this PR's E2E tests. View all artifacts
ℹ️ How to view screenshots
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
rust-testsCI job inpr-checks.ymlfails on dependabot PRs becausevx cargo llvm-covcan't findllvm-profdata:Root Cause
The workflow uses
dtolnay/rust-toolchain@stableto installllvm-tools-previewto the system Rust toolchain. However,vx cargo llvm-covuses the vx-managed Rust store (~/.vx/store/rust/...) which lacks these tools.Fix
Add an explicit step after vx setup to install
llvm-tools-previewthrough vx, ensuring the vx-managed Rust toolchain has the requiredllvm-profdatabinary.Affected PRs