tab: Fix pill indicator flicker when replacing tabs#2556
Open
BeratHundurel wants to merge 1 commit into
Open
Conversation
- Introduce indicator_moving on Tab - Propagate through TabBar to Tab state - Return moving flag from render_indicator and store on Tab - Refactor TabIndicatorBounds to track labels with sync_tabs - Use TabIndicatorBounds::new inits and apply sync logic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix transient visual artifacts when replacing selected animated tabs.
Cached indicator bounds could survive a tab replacement when the selected index remained unchanged. Replacing a longer tab with a shorter one therefore briefly rendered a clipped indicator. Indicator geometry is now invalidated when tab labels or count change and remains hidden until fresh bounds are measured.
The pill label fade could also replay a previous animation epoch after operations such as “Close All,” briefly flashing the normal text color. The fade now runs only while the indicator is actually moving.
Screenshot
Checklist
cargo runfor story tests related to the changes.