calendar: added support for custom calendar strings, and starting days#2548
Open
xrtxn wants to merge 1 commit into
Open
calendar: added support for custom calendar strings, and starting days#2548xrtxn wants to merge 1 commit into
xrtxn wants to merge 1 commit into
Conversation
Member
|
Hi, |
huacnlee
added a commit
that referenced
this pull request
Jul 13, 2026
## Summary - upgrade to rust-i18n 4.2.0 and register Story locales with `extend!(gpui_component)` - add French Calendar and DatePicker translations as a Story-only extension - keep the component’s built-in Italian and Traditional Chinese locales unchanged - add French to the Story language menu and cover extension fallback behavior with a test - document custom I18n setup, namespace rules, override priority, and locale selection in English and Simplified Chinese This uses rust-i18n’s locale extension mechanism to address the customization requirement discussed in #2548 without adding every downstream locale to gpui-component itself. Refs #2548 ## Test Plan - `cargo test -p gpui-component-story` - `git diff --check` - `bun run build` *(blocked by the current Bun/Vite Vue runtime: `crypto.hash is not a function` while compiling the existing `contributors.md`)* --------- Co-authored-by: Codex <codex@openai.com>
Contributor
Author
|
Thanks, this should work for me, this was my original idea too, but unsure how to implement it. However, please check out .first_day_of_week() as well, as this is still missing. If you rather I can implement the changes needed for this updated version, |
Member
|
first_day_of_week is ok to merge, you can cleanup you PR, then I will merge it. |
Contributor
Author
|
Please check it out, I cleaned up the code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2517
Description
Added support for custom weekday, month, and starting days. I found this to be the best tradeoff in terms of performance and ergonomy.
Screenshot
How to Test
First day
Week day and month day
Checklist
cargo runfor story tests related to the changes.