fix: add safe-area-inset-bottom to StatusBar for iOS home indicator - #538
Open
YA-shiKa wants to merge 1 commit into
Open
fix: add safe-area-inset-bottom to StatusBar for iOS home indicator#538YA-shiKa wants to merge 1 commit into
YA-shiKa wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
What type of PR is this?
What does this PR do?
Fixes the bottom status bar overlapping with the iOS home indicator gesture area. Imports
isMobilefromsrc/platform/index.jsand conditionally applies the existingsafe-area-inset-bottomCSS class (already defined insrc/styles/globals.css) to the StatusBar's root container when running on a mobile platform.Related issue(s):
Fixes #312
🧪 Testing
How was this tested?
Test scenarios covered:
npm run test) : all 5 existing StatusBar tests passisMobile()returnsfalseon desktop, so thesafe-area-inset-bottomclass is not applied and the layout is identical to beforenpm run tauri devon Windows only (not tested on macOS/Linux)📸 Screenshots/Videos
No visual change on desktop (verified via Tauri dev build on Windows). Behavior is conditional and only applies on iOS via
isMobile().📋 Checklist
For bug fixes:
🔄 Breaking Changes
📝 Additional Notes
This is a minimal, targeted fix as scoped in the original issue, no changes were needed to
platform/index.jsorglobals.css, sinceisMobile()and the.safe-area-inset-bottomclass already existed and just weren't wired together inStatusBar.jsx.🏷️ Release Notes
User-facing changes:
On iOS, the status bar no longer overlaps with the home indicator gesture area.
Developer-facing changes:
None.