Skip to content

fix: Fix release workflow - #3

Merged
Abhi347 merged 1 commit into
mainfrom
fix/fix-release-workflow
Jan 11, 2026
Merged

Abhi347 merged 1 commit into
mainfrom
fix/fix-release-workflow

Conversation

@Abhi347

@Abhi347 Abhi347 commented Jan 11, 2026

Copy link
Copy Markdown
Member

No description provided.

Copilot AI review requested due to automatic review settings January 11, 2026 14:36
@codecov

codecov Bot commented Jan 11, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@            Coverage Diff            @@
##              main        #3   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         4           
  Lines          246       246           
  Branches        68        60    -8     
=========================================
  Hits           246       246           
Flag Coverage Δ
unittests 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request removes automated semantic-release in favor of a manual release process. The changes shift from automated version bumping and changelog generation to a manual approach where developers must update versions and changelog entries themselves.

Changes:

  • Removed semantic-release and related plugins from dependencies
  • Deleted .releaserc.json configuration file
  • Updated release workflow to verify changelog entries and publish directly using pnpm
  • Added changelog verification step to CI workflow for pull requests with version changes

Reviewed changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
package.json Removed semantic-release and associated plugins from devDependencies
pnpm-lock.yaml Removed all dependencies related to semantic-release ecosystem (hundreds of transitive dependencies)
.releaserc.json Deleted semantic-release configuration file
.github/workflows/release.yml Replaced semantic-release automation with manual changelog verification and pnpm publish command
.github/workflows/ci.yml Added changelog verification for PRs that bump the version

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +50 to +52
run: |
pnpm config set //npm.pkg.github.com/:_authToken ${{ secrets.GITHUB_TOKEN }}
pnpm publish --no-git-checks

Copilot AI Jan 11, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pnpm publish command uses both an authentication token set via pnpm config set on line 51 and the NODE_AUTH_TOKEN environment variable on line 54. The NODE_AUTH_TOKEN environment variable is the standard way for pnpm to authenticate, but the config set command may conflict with it. Consider using only the environment variable approach for clarity. Additionally, when publishing to GitHub Packages, the registry URL should include the scope: //npm.pkg.github.com/@logkat/:_authToken to match the package name @logkat/broker-parser.

Suggested change
run: |
pnpm config set //npm.pkg.github.com/:_authToken ${{ secrets.GITHUB_TOKEN }}
pnpm publish --no-git-checks
run: pnpm publish --no-git-checks --registry=https://npm.pkg.github.com

Copilot uses AI. Check for mistakes.
Comment thread .github/workflows/ci.yml

# Get versions
CURRENT_VERSION=$(node -p "require('./package.json').version")
OLD_VERSION=$(git show main:package.json | node -p "JSON.parse(require('fs').readFileSync(0, 'utf-8')).version")

Copilot AI Jan 11, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version comparison logic has a potential issue. The command git show main:package.json | node -p "JSON.parse(require('fs').readFileSync(0, 'utf-8')).version" is attempting to read from stdin (file descriptor 0), but the JSON string is already piped in. The correct approach is to directly parse stdin without using require('fs').readFileSync. Consider changing to: git show main:package.json | node -p "JSON.parse(require('fs').readFileSync('/dev/stdin', 'utf-8')).version" or using a simpler approach like git show main:package.json | node -pe "JSON.parse(require('fs').readFileSync(0)).version".

Suggested change
OLD_VERSION=$(git show main:package.json | node -p "JSON.parse(require('fs').readFileSync(0, 'utf-8')).version")
OLD_VERSION=$(git show main:package.json | node -pe "JSON.parse(require('fs').readFileSync(0)).version")

Copilot uses AI. Check for mistakes.
NPM_TOKEN: ${{ secrets.GITHUB_TOKEN }}
NPM_CONFIG_REGISTRY: https://npm.pkg.github.com/
run: npx semantic-release
NODE_AUTH_TOKEN: ${{ secrets.GITHUB_TOKEN }}

Copilot AI Jan 11, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The release workflow doesn't create a GitHub release or tag when publishing the package. Consider adding a step to create a GitHub release using the gh release create command or an action like actions/create-release to track releases properly and provide release notes to users.

Suggested change
NODE_AUTH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
NODE_AUTH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
- name: Create Git tag and GitHub Release
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
run: |
VERSION=$(node -p "require('./package.json').version")
TAG="v$VERSION"
if git rev-parse "$TAG" >/dev/null 2>&1; then
echo "Tag $TAG already exists, skipping tag and release creation."
exit 0
fi
git tag "$TAG"
git push origin "$TAG"
gh release create "$TAG" --generate-notes

Copilot uses AI. Check for mistakes.
@Abhi347
Abhi347 merged commit b365ffb into main Jan 11, 2026
10 checks passed
@Abhi347
Abhi347 deleted the fix/fix-release-workflow branch January 11, 2026 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants