Skip to content

Add disable rate limiter option and environment variable support#63

Merged
AakashKhopade merged 3 commits into
logicmonitor:mainfrom
lm-ranjeet-gavali:disable_rate_limiter
Jul 4, 2025
Merged

Add disable rate limiter option and environment variable support#63
AakashKhopade merged 3 commits into
logicmonitor:mainfrom
lm-ranjeet-gavali:disable_rate_limiter

Conversation

@lm-ranjeet-gavali

Copy link
Copy Markdown
Contributor
  1. Add Disable Rate Limiter Option:
  • Introduced a NoopRateLimiter implementation.
  • When this is used, no rate limiting is applied — all requests are allowed through unconditionally.
  • Useful for development, testing, or environments where rate limiting is not needed.
  1. Support for Environment Variables:
  • If the rate limiter is enabled and explicit values are not set, the configuration will now:

    • First look for environment variables for request and span limits.
    • If env variables are also absent, it will fall back to default hardcoded values.
  • This allows easier runtime customization without code changes.

  1. Added "" string to the ConvertToLMLogInput methods , to resolve errors.

@khyatigandhi0612 khyatigandhi0612 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me

@AakashKhopade AakashKhopade merged commit 4fbeb85 into logicmonitor:main Jul 4, 2025
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants