feat(lm-logs): parameterised HTTP/S proxy support#631
Open
lm-aditya-kadam wants to merge 2 commits into
Open
Conversation
Add proxy.{url,user,pass,noProxy} on lm-logs (with a matching
global.proxy fallback) so customers can enable an outbound HTTP/S
proxy via --set / values, without editing the DaemonSet template.
Mirrors argus/lm-container conventions for consistent UX in standalone
and umbrella installs.
- New helper lm-logs.proxyEnv emits http_proxy / https_proxy / no_proxy
(plus uppercase variants) on the fluentd container only when a URL
is configured. user/pass are URL-encoded into the URL.
- Safe default no_proxy (kubernetes.default.svc,.svc,.cluster.local,
localhost,127.0.0.1) keeps the fluentd kubernetes_metadata filter
direct so kube API calls are not tunnelled through the proxy.
- Precedence: .Values.proxy.<f> overrides .Values.global.proxy.<f>.
- values.schema.json updated for both blocks.
- Chart version bumped to 1.1.1-rc03.
Co-authored-by: Cursor <cursoragent@cursor.com>
lm-aditya-kadam
requested review from
choudharypooja,
lmshubhashri and
lmvaibhavk
as code owners
Co-authored-by: Cursor <cursoragent@cursor.com>
lm-aditya-kadam
force-pushed
the
feat/lm-logs-proxy-support
branch
from
0f8c92b to
87d3457
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add proxy.{url,user,pass,noProxy} on lm-logs (with a matching global.proxy fallback) so customers can enable an outbound HTTP/S proxy via --set / values, without editing the DaemonSet template. Mirrors argus/lm-container conventions for consistent UX in standalone and umbrella installs.