Skip to content

fix(nav): recenter the logo mark's L and add pointer cursor to nav buttons #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Mavengence merged 2 commits into from
Aug 12, 2026
Merged

fix(nav): recenter the logo mark's L and add pointer cursor to nav buttons #37

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1117b42
fix(nav): recenter the logo mark's "L" and add pointer cursor to nav …
Mavengence Aug 11, 2026
83bd615
fix(nav): drop an em-dash from a JSX code comment
Mavengence Aug 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 16 additions & 5 deletions packages/website/src/components/nav.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,8 +223,13 @@ function LogoWordmark({
const lOpacity = useTransform(scrollY, [40, 120], [1, 0]);
const lWidth = useTransform(scrollY, [40, 120], [14, 0]);

/* The "." in the icon fades out as it merges with the wordmark */
/* The "." in the icon fades out as it merges with the wordmark. Width
collapses over the same range as opacity, since the dot is an inline
sibling of "L" inside a `justify-content: center` box, so fading it to
`opacity: 0` alone left its layout width in place, which kept "L" off
centre (reading as if the square clipped its left side once rotated). */
const dotOpacity = useTransform(scrollY, [60, 130], [1, 0]);
const dotWidth = useTransform(scrollY, [60, 130], ["0.4em", "0em"]);

return (
/* No clip on this box. The square's rotated bounding box and its hard
Expand Down Expand Up @@ -260,7 +265,13 @@ function LogoWordmark({
fontWeight: 900,
}}
>
L<m.span style={{ opacity: dotOpacity }}>.</m.span>
L
<m.span
className="inline-block overflow-hidden"
style={{ opacity: dotOpacity, width: dotWidth }}
>
.
</m.span>
</m.span>
</m.div>

Expand Down Expand Up @@ -550,7 +561,7 @@ export function Nav() {
onClick={() => setOpenDropdown(openDropdown === id ? null : id)}
onKeyDown={handleTriggerKeyDown(id)}
className={cn(
"inline-flex min-h-11 items-center gap-1 px-1 text-sm outline-none transition-colors hover:text-foreground focus-visible:ring-2 focus-visible:ring-brand-orange focus-visible:ring-offset-2 focus-visible:ring-offset-background",
"inline-flex min-h-11 cursor-pointer items-center gap-1 px-1 text-sm outline-none transition-colors hover:text-foreground focus-visible:ring-2 focus-visible:ring-brand-orange focus-visible:ring-offset-2 focus-visible:ring-offset-background",
active ? "text-foreground" : "text-muted-foreground",
)}
>
Expand Down Expand Up @@ -773,7 +784,7 @@ export function Nav() {
tabIndex={mobileOpen ? -1 : undefined}
aria-hidden={mobileOpen || undefined}
className={cn(
"js-mobile-nav-toggle inline-flex min-h-11 min-w-11 items-center justify-center rounded-lg p-2 text-muted-foreground outline-none transition-colors hover:text-foreground focus-visible:ring-2 focus-visible:ring-brand-orange focus-visible:ring-offset-2 focus-visible:ring-offset-background",
"js-mobile-nav-toggle inline-flex min-h-11 min-w-11 cursor-pointer items-center justify-center rounded-lg p-2 text-muted-foreground outline-none transition-colors hover:text-foreground focus-visible:ring-2 focus-visible:ring-brand-orange focus-visible:ring-offset-2 focus-visible:ring-offset-background",
mobileOpen && "pointer-events-none invisible",
)}
aria-label={copy.openMenu}
Expand Down Expand Up @@ -863,7 +874,7 @@ export function Nav() {
<button
type="button"
onClick={closeMobileMenu}
className="ml-auto inline-flex min-h-11 min-w-11 items-center justify-center rounded-lg text-muted-foreground outline-none transition-colors hover:text-foreground focus-visible:ring-2 focus-visible:ring-brand-orange focus-visible:ring-offset-2 focus-visible:ring-offset-background"
className="ml-auto inline-flex min-h-11 min-w-11 cursor-pointer items-center justify-center rounded-lg text-muted-foreground outline-none transition-colors hover:text-foreground focus-visible:ring-2 focus-visible:ring-brand-orange focus-visible:ring-offset-2 focus-visible:ring-offset-background"
aria-label={copy.closeMenu}
>
<X size={19} aria-hidden="true" />
Expand Down
Loading