document MNP jobs execution#709
Open
HarshCasper wants to merge 1 commit into
Open
Conversation
HarshCasper
requested review from
nik-localstack,
pinzon and
quetzalliwrites
as code owners
Deploying localstack-docs with
|
| Latest commit: |
b8a2621
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://d0cdf84c.localstack-docs.pages.dev |
| Branch Preview URL: | https://doc-228-doc-batch-mnp-jobs-e.localstack-docs.pages.dev |
nik-localstack
left a comment
nik-localstack
left a comment
Contributor
There was a problem hiding this comment.
Thanks for adding this. I have a few comments about the structure.
|
|
||
| Array jobs are supported in sequential mode only. | ||
|
|
||
| [Multi-node parallel jobs](#multi-node-parallel-jobs) are supported on EC2-backed compute environments only. |
Contributor
There was a problem hiding this comment.
question: Why do we document this ? That's a real AWS contraint.
Comment on lines
+238
to
+242
| A few behaviors to keep in mind: | ||
|
|
||
| - The parent job's outcome follows the main node. | ||
| - A worker failure does not fail the parent. | ||
| - Terminating the parent job stops all of its nodes. |
Contributor
There was a problem hiding this comment.
This reads like they're localstack only limitation but they are also happening in AWS. I suggest we remove them.
| - Terminating the parent job stops all of its nodes. | ||
|
|
||
| ### Node environment variables | ||
| In addition to the [standard Batch environment variables](#current-limitations), each node receives the following multi-node parallel variables: |
Contributor
There was a problem hiding this comment.
It's strange that we anchor to the current limitation. Can we create a separate section where we list the supported env vars. That way we won't need to duplicate the MNP variables.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes DOC-228