Fix Android pointer grabs after right-click and focus loss - #299
Draft
4Luke4 wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix Android pointer input state getting stuck after right-clicks, interrupted gestures, and app focus transitions.
Root cause
Android's
button_state()describes the button mask after the current motion event. On affected devices, a secondary-button release therefore arrives with an empty mask. The patched winit Android backend maps that empty mask to the left button, causing LocalDesktop to send a left-button release after a right-button press. The Wayland compositor never receives the matching right-button release and retains the pointer grab, making subsequent clicks appear frozen.Android may also interrupt an active gesture when the app loses focus without delivering the corresponding release or cancellation event.
Changes
User impact
This should prevent the desktop from becoming unresponsive after:
Related issues
Addresses the shared input-state failure reported in:
Issue #278 concerns cursor ownership and sizing rather than button-state recovery. It should be implemented separately because it requires Android platform cursor visibility support plus compositor-side cursor rendering; coupling that work to grab recovery would make regressions substantially harder to isolate.
Validation
mainand contains one modified file.Suggested device checks