[GG] Measure repeatable activation peak after kernel warmup - #198
Conversation
|
Warning Review limit reached
Next review available in: 56 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai review |
✅ Action performedReview finished.
|
2d9c980
into
local-inference-lab:dev/gilded-gnosis
Problem
determine_available_memory()profiles a warmup pass and a second serving pass inside one peak-memory window. The first pass can include one-time compiler or loader temporaries. A transient on one rank then permanently reduces the distributed KV-cache allocation even though that memory is freed before serving.This was reproduced with the TP4/DCP4 EXL3 path: identical cold starts varied from 834,560 down to 778,496 KV tokens, with one rank reporting 2.10 GiB peak activation while all ranks had identical live memory before the second pass.
Fix
Reset only the accelerator peak counter after persistent kernel warmup and before the second profile pass. Live allocations are not freed or hidden; persistent buffers remain counted relative to the original baseline. The second pass establishes the repeatable serving activation peak.
A regression test locks the ordering: initial profile, compressor warmup, kernel warmup, peak reset, measured profile.
Validation
git diff --checkandpy_compile: cleanPaired EXL3 consumer: #190