moe: add isolated mixed K3/K4 Trellis comparison path - #99
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Superseded by #104 and the matching vLLM integration in local-inference-lab/vllm#190. Thank you for publishing the comparison path and measurements. We reproduced the useful architectural ideas here: one global route pack, global expert descriptors, a single cooperative mixed grid, and exact-M specialization. The final implementation differs in three material ways:
#104 also adds production-shape GPU regression coverage, checkpoint validation tools, and the measured TP4/DCP4 results ( |
Draft comparison PR ahead of r14. This adds an opt-in mixed K3/K4 Trellis path for
willfalco/GLM-5.2-EXL3-TR3-3.25bpw.The existing uniform K3 path is untouched: no existing kernel function or class changed, and
W4A16FusedMoeKernelis AST-identical to currentmaster.We have struggled to close the mixed-model gap. Our current TP4/DCP4 results are:
This is for pre-r14 comparison, not merge yet. We would appreciate a diff against the reported 48 MTP0 / 106 MTP3 mixed path.
Validation:
py_compile, Ruff, and source-isolation checks passed