[EXL3] preserve mixed-prefill numerics with paired M8 FC2 - #111
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Superseded by #112. The successor preserves the paired-M8 numerical contract without the stacked feature-branch base and is the PR used by the r20 release manifest. |
What
Preserves block-64 mixed-K3/K4 prefill route packing and bounded workspace
while restoring deterministic block-8 FC2 arithmetic inside the same
cooperative grid.
The kernel maps each FC2 compute block to its block-64 metadata parent,
computes exact M8 subtiles, and reuses each decoded weight fragment across a
pair of independent M8 outputs. The mixed-Trellis ABI is bumped so stale
cubins cannot be reused across the launch-contract change.
Why
Captured-input checks localized the mixed-prefill quality regression to FC2:
FC1 and activation outputs were bit exact, while the original block-64 FC2
path changed reduction order and was nondeterministic at the production tile
geometry. On the prescribed 2,047-position KLD gate, that path measured
0.07888687230031491versus the0.07776700789368204reference.The paired-M8 implementation restores reference arithmetic without returning
to serial homogeneous K3/K4 launches or unbounded workspace.
Validation
Component-specific gates:
overlay;
exact, with zero changed elements;
M8 implementation (1.7187x);
0.07776700789368204over 2,047 positions, exactreference parity.
The combined r19 qualification (TR3-3.36, TP4/DCP4, dynamic NVFP4 MLA KV,
exact selector,
i8_hier) measured:cached_tokens=0;738216,cached_tokens=0.No separate r19 KLD run is claimed; r19 re-ran the production-width exact
operator and long-context behavioral gates against source bytes identical to
the KLD-qualified implementation.
Dependency
This PR is stacked on #110 so its review diff
contains only the paired-M8 exact-FC2 implementation. Retarget to
masterafter #110 merges.
Companion vLLM planner PR:
local-inference-lab/vllm#226