Add support to LOCO fitting with ID's local quads and skew quads - #193
Draft
vellosok75 wants to merge 3 commits into
Draft
Add support to LOCO fitting with ID's local quads and skew quads#193vellosok75 wants to merge 3 commits into
vellosok75 wants to merge 3 commits into
Conversation
… previous LOCO fit - allows selection of quadrupoles families for performing the fit: currently the fitting does not seem to be working, under investigation (find orbit error during new parameters evaluation within the LOCO loop) - allows starting point of the fitting to be performed from an initial LOCO fit
- new arg `id-name` forces fit to be carried out with quad magnets adjacent to the corresponding ID, as well as the ID's skew quads - if using a previous fitted model, will not fit gains and couplings
vellosok75
requested review from
Gabrielrezende-asc,
JeffersonBarrosVieira,
VitorSouzaLNLS,
fernandohds564 and
xresende
April 27, 2026 20:56
Gabrielrezende-asc
approved these changes
Apr 28, 2026
- when starting from a previous loco fitted model, the tunes will not match measured ones (same old tune problem) - if tune is corrected, quadrupole changes associated with this correction may be difficult to isolate from the actual changes needed to fit the data starting fom the previous fit model - the new arg allows to bypass the tune correction
JeffersonBarrosVieira
approved these changes
May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows carrying out fitting with ID's local quads and skew quads by introducing the
--id-nameargument (ID famname in pymodels). Also introduces the--filename-init-fitarg, which loads the data from a previous LOCO fit, and starts optimization from that point, with frozen gains and rolls.Depends on lnls-fac/apsuite#324
I'll add usage instructions and the tests I carried out as soon as I can.