Update RF devices on machine shutdown script - #169
Conversation
| for cavmon in cavmons: | ||
| if not self._wait_devices_propty( |
There was a problem hiding this comment.
Hi @murilobalves , in this case it seems we don't need the loop here.
There was a problem hiding this comment.
what about this point, @anacso17? Since Murilo is not here anymore, could you fix this?
JeffersonBarrosVieira
left a comment
There was a problem hiding this comment.
I made the updates by removing the IDs that are not installed and including the new IDs. I also noticed that we forgot to add the Carnauba APU device to the dev-packages repository, so I made a PR there as well.
devices['apu22_17SA'] = IDParking(
_ID.DEVICES.APU.APU22_17SA, log_callback=self._log_callback
) # SPUThis call would be broken.
|
Since this branch wasn't merged, i took the opportunity to update the IPE ID parking initialize based on the device implementation of the new IPE source in the dev-packages repository, as per the PR below: |
|
The ARIRANHA APU wasn't added to dev-packages, so i made a pull request here: add-apu22-ariranha. I also took the opportunity to add the ARIRANHA APU parking to this shutdown script pull request. |
TODO: