Skip to content

Update RF devices on machine shutdown script - #169

Open
murilobalves wants to merge 5 commits into
masterfrom
update-rf-devices
Open

Update RF devices on machine shutdown script#169
murilobalves wants to merge 5 commits into
masterfrom
update-rf-devices

Conversation

@murilobalves

@murilobalves murilobalves commented Sep 30, 2024

Copy link
Copy Markdown
Contributor

TODO:

Comment on lines +533 to +534
for cavmon in cavmons:
if not self._wait_devices_propty(

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @murilobalves , in this case it seems we don't need the loop here.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what about this point, @anacso17? Since Murilo is not here anymore, could you fix this?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xresende
xresende marked this pull request as ready for review July 25, 2025 17:20
@anacso17
anacso17 marked this pull request as draft July 28, 2025 14:00

@JeffersonBarrosVieira JeffersonBarrosVieira left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made the updates by removing the IDs that are not installed and including the new IDs. I also noticed that we forgot to add the Carnauba APU device to the dev-packages repository, so I made a PR there as well.

devices['apu22_17SA'] = IDParking(
       _ID.DEVICES.APU.APU22_17SA, log_callback=self._log_callback
)  # SPU

This call would be broken.

@JeffersonBarrosVieira
JeffersonBarrosVieira marked this pull request as ready for review July 28, 2025 14:02
@JeffersonBarrosVieira

JeffersonBarrosVieira commented Apr 10, 2026

Copy link
Copy Markdown

Since this branch wasn't merged, i took the opportunity to update the IPE ID parking initialize based on the device implementation of the new IPE source in the dev-packages repository, as per the PR below:

add-ue44-device

@JeffersonBarrosVieira

Copy link
Copy Markdown

The ARIRANHA APU wasn't added to dev-packages, so i made a pull request here: add-apu22-ariranha. I also took the opportunity to add the ARIRANHA APU parking to this shutdown script pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants