Use new optics consts classes - #1237
Draft
xresende wants to merge 18 commits into
Draft
Conversation
fernandohds564
requested changes
May 7, 2026
| def __init__(self, acc): | ||
| """Init1 method.""" | ||
| self.acc = acc.upper() | ||
| self.acc = acc |
Contributor
There was a problem hiding this comment.
I don't understand. How can you be sure that acc is one of the classes you defined? I think you have to parse this argument here.
| self.nr_svals = min(self.nr_corrs, 2 * self.nr_bpms) | ||
| self.circum = 21.2477 if self.acc == "TB" else 26.8933 # in meters | ||
| self.rev_per = self.circum / 299792458 # in seconds | ||
| self.circum = self.acc.length |
Contributor
There was a problem hiding this comment.
I think if the self.acc has the attribute length, we don't need this self.circum anymore. You can remove it and change the places where it is used.
xresende
marked this pull request as draft
May 20, 2026 20:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
needs #1236