Skip to content

Update machine report classes - #1207

Merged
anacso17 merged 4 commits into
masterfrom
update-macreports
Dec 3, 2025
Merged

Update machine report classes#1207
anacso17 merged 4 commits into
masterfrom
update-macreports

Conversation

@anacso17

@anacso17 anacso17 commented Nov 4, 2025

Copy link
Copy Markdown
Contributor
  • Add manual failure annotation for October 18th problem
    • We had problems with PPS in this period (user shift without beam and with wrong machine shift annotations).
  • Do not ignore wrong shift annotations in the beggining of an analized period
    • There is a feature that was introduced to ignore wrong shift annotations within 1min (for example, to not indicate user shift problems if the MachShift mode PV changes in value 1min later than scheduled). This commit changes this feature to not ignore wrong shift annotations in the beggining of an analized period. This was causing a wrong indication of transition from "correct shift" to "wrong shift" when the analized period started with a wrong shift and, as a consequence, causing a wrong beam dump annotation.
  • Update example of code to generate a report

We had problems with PPS in this period (user shift without beam and with wrong machine shift annotations).
… of an analized period

There is a feature that was introduced to ignore wrong shift annotations within 1min (for example, to not indicate user shift problems if the MachShift mode PV changes in value 1min later than scheduled). This commit changes this feature to not ignore wrong shift annotations in the beggining of an analized period. This was causing a wrong indication of transition from "correct shift" to "wrong shift" when the analized period started with a wrong shift and, as a consequence, causing a wrong beam dump annotation.
@xresende

xresende commented Nov 5, 2025

Copy link
Copy Markdown
Contributor

@anacso17 , did you notice that integration tests are failing? I looked at the output bu could not understand what is going on. maybe it is a temporary service instability?

@anacso17

anacso17 commented Nov 5, 2025

Copy link
Copy Markdown
Contributor Author

@anacso17 , did you notice that integration tests are failing? I looked at the output bu could not understand what is going on. maybe it is a temporary service instability?

Hi @xresende , this is because of the fail in mathphys wheel build, which will be fixed with this PR lnls-fac/mathphys#37.

@anacso17
anacso17 merged commit 004c031 into master Dec 3, 2025
4 checks passed
@anacso17
anacso17 deleted the update-macreports branch December 3, 2025 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants