BUGFIX: Operations on "time aware" vectors were being performed even if they were empty. - #88
Merged
Merged
Conversation
VitorSouzaLNLS
requested review from
HenriqueWS11,
fernandohds564,
otavio-silveira,
vellosok75 and
xresende
March 27, 2026 23:28
fernandohds564
approved these changes
Mar 31, 2026
HenriqueWS11
approved these changes
Apr 1, 2026
vellosok75
approved these changes
Apr 1, 2026
otavio-silveira
approved these changes
Apr 6, 2026
xresende
approved these changes
Apr 9, 2026
Contributor
|
@VitorSouzaLNLS, remember to change the version before merging. I also think you can create a release (talk to @xresende or @anacso17 for help) and edit the version in the new deploy PR at lnls-ansible repository, once that PR is created. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the new accelerator's function
update_time_aware_infothe operationtime_aware_displacements.back() += line_length - cum_lengthwas being performed (or trying to be performed) even if the vector was empty, as in cases like transport lines with no time-aware element.Thanks to @otavio-silveira and @HenriqueWS11 for our discussion about "twiss matching" that led us to find out this bug.