Add bumps to commisslib - #315
Open
xresende wants to merge 25 commits into
Open
Conversation
… into add-bumps-to-commisslib
Contributor
|
Some changes still need to be tested during machine studies shifts, but I believe this first version is ready to be merged. |
fernandohds564
requested changes
Feb 4, 2026
vellosok75
reviewed
Feb 6, 2026
vellosok75
reviewed
Feb 6, 2026
vellosok75
approved these changes
Feb 6, 2026
Contributor
|
Thanks for the review! In our next machine study (Monday), I will use some time to test the scans. After this, some other bugs will be corrected, and I think the class will be ready to be merged |
Gabrielrezende-asc
approved these changes
Feb 6, 2026
fernandohds564
requested changes
Feb 9, 2026
… into add-bumps-to-commisslib
fernandohds564
left a comment
fernandohds564
left a comment
Contributor
There was a problem hiding this comment.
@Gabrielrezende-asc and I talked offline about some suggestions. I'll wait for a new version for revision.
Contributor
|
@Gabrielrezende-asc , what is the status of this PR? have you implement the changes we discussed? Is it ready for review again? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.