feat(ibex): propagate httpCode from ibex-client 3.2.0 + structural 429 detection (ENG-485)#439
Merged
Merged
Conversation
…9 (ENG-485) ibex-client 3.2.0's ApiError now carries the wrapped HTTP status as httpCode (previously the constructor discarded the original error, which is why the IbexError.httpCode line sat commented out — it had nothing to read). This: - bumps ibex-client ^3.1.0 -> ^3.2.0 - turns on IbexError.httpCode (from ApiError.httpCode) - makes the cutover rate-limit detection structural-first: httpCode === 429 (returned IbexErrors) or status === 429 (raw thrown FetchErrors), with the "too many requests" text match retained as a fallback for anything carrying neither. Refs ENG-485 (upstream half: lnflash/ibex-client#11, released v3.2.0)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Downstream half of ENG-485, now unblocked: ibex-client#11 (released v3.2.0) makes
ApiErrorcarry the wrapped HTTP status ashttpCode— previously its constructor wassuper(e.stack), discarding the status entirely, which is why flash'sIbexError.httpCodesat commented out.ibex-client^3.1.0 → ^3.2.0IbexError.httpCodenow populated fromApiError.httpCodehttpCode === 429(returned IbexErrors) or.status === 429(raw thrown FetchErrors), keeping the"too many requests"text match as fallback for anything carrying neitherTest plan
Refs ENG-485
🤖 Generated with Claude Code