fix: convert cash send amounts at API boundary#659
Closed
forge0x wants to merge 1 commit into
Closed
Conversation
a1f9ea5 to
d669ae8
Compare
Cleanup pass: dedupe the cash-wallet check into a shared isCashWalletCurrency helper (was inlined identically in utils.ts and send-bitcoin-confirmation-screen.tsx) and revert an unrelated import reformat in intraledger.ts. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
d669ae8 to
49dc630
Compare
Contributor
|
| Line | Rule | Issue |
|---|---|---|
52:14 |
@typescript-eslint/ban-types |
Uses {} as a type (means "any non-nullish value" — likely wants object / Record<string, never>) |
270:59 |
no-implicit-coercion |
!!paymentError-style coercion — use Boolean(paymentError) |
281:33 |
@typescript-eslint/no-unused-vars |
colors defined but never used |
✖ 5 problems (3 errors, 2 warnings)
1 error and 0 warnings potentially fixable with the `--fix` option.
(#270 and #281 are auto-fixable via eslint --fix; the {} type at #52 needs a manual decision on the intended type.)
These would be a quick separate cleanup commit if you want the file to pass a whole-file lint — happy to take it on if useful, but kept it out of this PR to avoid unrelated churn.
Contributor
|
Closed by lnflash/flash#413 commit lnflash/flash@2a9e2ae |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
UAT
$1.23/$1.24 (amount+fee)balance error for$0.05sendsTests
yarn test __tests__/payment-details __tests__/payment-destination --runInBandyarn tsc:checkyarn graphql-checkyarn check:codegengit diff --checkStacked against #621 (
feat/fygaro).