Conversation
irisqul
reviewed
May 1, 2026
| assert response.status_code == 201 | ||
| assert response.json() == {'ok': True} | ||
|
|
||
| delete_courier_by_login_password(payload['login'], payload['password']) |
There was a problem hiding this comment.
Можно лучше: супер что очищается БД, но делать это стоит в фикстуре, чтобы даже если в тесте что-то пошло не по плану, Бд всё же осталась в изначальном состоянии
|
|
||
| @allure.title('Нельзя создать двух одинаковых курьеров') | ||
| def test_create_same_courier_returns_error(self): | ||
| payload = create_courier_payload() |
There was a problem hiding this comment.
можно лучше: наличие зарегистрированного курьера в данном тесте предусловие, т.е. лучше перенести в фикстуру
|
|
||
| response = requests.post(BASE_URL + LOGIN_COURIER, json=payload) | ||
|
|
||
| if field == 'password': |
There was a problem hiding this comment.
Нужно исправить: условий в тестах быть не может, тест всегда однозначен. Если это не вписывается в параметризацию, значит ее быть не должно и это просто несколько отдельных тестовых методов
| @allure.title('Курьера можно создать') | ||
| def test_create_courier_success(self): | ||
| payload = create_courier_payload() | ||
| response = requests.post(BASE_URL + CREATE_COURIER, json=payload) |
There was a problem hiding this comment.
Нужно исправить: Над каждым логическим методом (запрос через requests) нужно прописать декоратор allure.step
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.