Repository navigation
build(deps): reviewed pgx 5.12.0 and yaml 3.0.6 update - #94
Merged
Merged
Conversation
Review candidate for Dependabot #89, including yaml v3.0.6. Retain the v5.11.0 capability pin until the independent hosted psql byte oracle passes. Temporary branch-only review job leaves ordinary checks unchanged and will be removed before the replacement PR opens. Signed-off-by: Vijay <evijay@gmail.com>
The production graph remains 267 packages with the same eight pgx runtime packages; only the approved DialContext/LookupHost boundary remains. Source review, govulncheck, TLS/credential checks and the hosted real PostgreSQL/psql byte oracle passed before moving the pin. Update the SBOM expectation and restore the normal CI workflow, retaining the pre-pin review commit in history. The replacement PR requires Claude pre-merge review. Signed-off-by: Vijay <evijay@gmail.com>
Refresh the draft database-runtime PR against current main without rewriting history. Preserve the reviewed pgx/yaml versions and exact capability pin; Claude pre-merge review is still required. Signed-off-by: Vijay <evijay@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Signed and DCO-signed replacement for Dependabot #89, carrying pgx v5.11.0 to v5.12.0 and go.yaml.in/yaml/v3 v3.0.5 to v3.0.6.
Claude's pre-merge check: PASS on final head
d1981cd4, forwarded by Vijay on November 10, 2026. The reviewed database-runtime gate is satisfied. No release, tag or settings changes; this ships with the next fleetdiff release.Runtime Review Before Re-pinning
Database Verification Before Re-pinning
The single hosted pre-pin review job passed:
https://github.com/llm-measurement/fleetdiff/actions/runs/42815668200/job/129828005482
It verifies real TLS positive/negative cases, credential permissions/source isolation, read-only snapshots and byte-identical native exports against the canonical psql recipe across formats, routing, usage details, daily counters and request tags. It ran 76 tests with seven documented opt-in skips, including the multi-GB 10M-row case.
That review ran with the old capability pin still in place. The ordinary CI job therefore retained the expected pin-only failure; it was not relabeled as a passing run. The temporary branch-only review job was then removed and the normal CI workflow restored byte for byte. All signed review and main-refresh commits remain in history; no rewrite.
Final Delta and Checks
Only after the above passed, update the exact eight-package module pin and the release SBOM expectation to v5.12.0. Keep the capability allowlist unchanged.
Local post-pin network guard, full Go tests and go vet pass. Normal hosted checks on the final PR head must pass before merge. Local Docker and cluster checks were not run; the real database oracle ran on GitHub-hosted infrastructure, leaving the active local testbed untouched.
Security Advisories And Reviewed Reachability
pgx v5.12.0 fixes GHSA-j38q-h3ph-jjpq and GHSA-95fj-3fxw-g62g. Both are high-severity advisories published in the pgx repository on October 31, 2026.
Claude's reviewed fleetdiff v0.14.0 path reaches neither: it never imports the pgx root package, so it cannot call
SendBatch; it never setsrequire_authorchannel_binding; and remote hosts requireverify-full. The URL allowlist is unchanged.neutralConfigstrips every inheritedPG*variable by prefix, and the replacement verify-fullTLSConfigcarries no client certificate, so the newsslcertmodedefault has no certificate to send. ThePGSSLCERTMODEisolation regression is retained.