Repository navigation
Langfuse: enum-only observation severity for next release - #81
Merged
Merged
Conversation
Signed-off-by: Vijay <evijay@gmail.com>
Signed-off-by: Vijay <evijay@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #80 in the next release only. The published v0.13.0 tag and artifacts are unchanged; no version bump, release, installer, dependency or workflow change is included.
levelenum:DEFAULT,DEBUG,WARNING,ERROR. Normalize missing/null/empty/non-string/unrecognized levels to a fixedunknownlabel; no aliases, trimming or coercion.Privacy
JSON retains at most a 44-byte enum lookahead (enough for seven fully escaped ASCII characters); CSV buffers at most seven enum bytes and discards an overlong value while validating the rest. Only recognized enum strings or the fixed unknown label enter the projected row. Existing row/file/directory bounds remain in force.
Observation input/output/metadata/tool_calls/status_message values are still syntax-scanned and discarded, never decoded into payload strings or printed. Tests cover all four enums, escaped keys/values, whitespace, missing/null/invalid/long/nested values, duplicate/conflicting projections, cross-format normalization, late malformed data, and privacy sentinels.
Verification
go test -race -p 2 ./...andgo vet -p 2 ./....Supplied Review And Final Fixes
Vijay supplied Claude's review approving the enum parsing, bounds, privacy and semantics. The six requested pre-merge fixes are included:
level), never its value. Fixed-size field hashes preserve normalized deduplication and private diagnostics.Vijay authorized merge only after green final heads. No release is authorized. No automatic contact or fabricated reviewer identity is involved; the supplied review and instructions came directly through Vijay.