fix(ci): close remaining uv sync diagnostic gaps (#8249) - #8446
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Team Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🔍 PR Contract Check SummaryOverall Status: 🟢 PASSED
|
ll7
left a comment
There was a problem hiding this comment.
Exact-head implementation review
Reviewed PR #8446 at exact head 8e7015c578279c1d4e1dd31279b0143bf9161eec against
origin/main 5f476625eba9c4ae2fa5770781852b78c865fd8b.
Scope and design
This is a support/tooling-only successor for #8249. It removes the unbounded uv cache size
probe, bounds GNU du calls with an explicit positive timeout and kill-after grace period, keeps
the direct-du fallback for hosts without GNU timeout, and exposes timeout/error markers while
preserving advisory zero-exit behavior. It makes no research, benchmark, model, metric, or
paper-facing claim.
Validation
pytest -q tests/dev/test_ci_uv_sync_diag.py tests/test_ci_script_contract.py— 165 passed.- Ruff 0.16.5 check/format,
bash -n scripts/dev/ci_uv_sync_diag.sh,
git diff --check, and cleangit merge-tree --write-tree origin/main HEAD— passed. - Hosted status is not yet terminal:
smoke-artifactsandchanged-coverage-gateremain in
progress, so no hosted success is inferred.
Findings and disposition
No actionable P0–P3 implementation finding was identified. The timeout detection, GNU capability
check, non-timeout error reporting, compatibility fallback, and no-uv cache size contract are
covered by the focused tests. The PR is current-base, non-draft, and has no domain or evidence
hold in its declared contract; final admission still requires terminal hosted checks and the
repository’s guarded merge receipt.
Decision: accept the implementation slice provisionally, subject to exact-head hosted checks and
the canonical receipt. No source repair is required.
gate-verdict: accepted @ 8e7015c
pr-metadata: reconciled @ 4f7a712bc6fa0d761e1bcfcc6053a318b46e3b39658b8951284e208764e9b345
ll7
left a comment
There was a problem hiding this comment.
Exact-head implementation review
Reviewed PR #8446 at exact head 8e7015c578279c1d4e1dd31279b0143bf9161eec against
origin/main 5f476625eba9c4ae2fa5770781852b78c865fd8b.
This is a support/tooling-only successor for #8249. It removes the unbounded uv cache size
probe, bounds GNU du calls with an explicit positive timeout and kill-after grace period, keeps
the direct-du fallback for hosts without GNU timeout, and exposes timeout/error markers while
preserving advisory zero-exit behavior. It makes no research, benchmark, model, metric, or
paper-facing claim.
The focused proof passed: 165 passed across the changed diagnostic and script-contract tests;
Ruff 0.16.5, formatting, shell syntax, diff, and merge-tree checks passed. Hosted CI is now
terminal for this exact head with 32 success and 1 skipped checks. No actionable P0–P3
implementation finding was identified, and no domain, scientific-evidence, legal, security, or
dependency hold is declared. The implementation is accepted for the guarded merge path, subject
to the repository’s exact-head merge receipt and merge-queue gate.
Decision: accept this tooling slice. No source repair is required.
gate-verdict: accepted @ 8e7015c
pr-metadata: reconciled @ b546fe9f1c49ed8eae046bcfffa581cbf3935f64751e8f7fa2699ba138c56b4d
Summary
This successor closes the remaining boundedness gap in the CI
ci_uv_sync_diagprobe. It removesthe unbounded
uv cache sizetraversal and makes both advisoryduprobes deadline-aware anddiagnostically explicit.
Linked Issues
Stack / Dependency
main.What Changed
uv cache sizecache-root traversal.ROBOT_SF_DIAG_DU_TIMEOUT_SECONDSvalue, defaulting invalid values (includingzero) to 10 seconds.
timeout(1)explicitly and use--kill-after=2safter the configured deadline.ok,timed-out, orerrorsizing status markers and exit codes for cache and virtualenvprobes.
uvregression, zero timeout, hard timeout timing,non-timeout errors, no-GNU fallback behavior, and the script contract.
Why It Matters
The diagnostic remains advisory and exits zero, while its expensive cache and virtual-environment
walks no longer hide failures or consume the full readiness test budget. Hosts without GNU
timeout(1)retain the prior direct-dufallback and ordinary output keys.Research / Evidence Notes
Not applicable — this is a CI/tooling reliability change with no research, benchmark, metric, or
paper-facing claim.
Validation / Proof
tests/dev/test_ci_uv_sync_diag.py: 12 passed.tests/test_ci_script_contract.py: 153 passed.bash -n scripts/dev/ci_uv_sync_diag.sh: passed.BASE_REF=origin/main PR_READY_MODE=final ... scripts/dev/pr_ready_check.sh: passed oncommitted head
8e7015c578279c1d4e1dd31279b0143bf9161eecagainst base5f476625eba9c4ae2fa5770781852b78c865fd8b.Risks / Rollback
The no-GNU fallback remains intentionally unbounded for compatibility with stock macOS-style
hosts. Revert commit
8e7015c57to restore the preceding diagnostic implementation if needed.Docs / Provenance
No durable benchmark or model artifacts were produced. Readiness receipts remain worktree-local
ignored output; the source contract and reproducible test fixtures are tracked in this PR.
Downstream Propagation
Not applicable — support/tooling change; no benchmark, metric, model, claim-map, registry, or
durable evidence update is required.
Follow-Up / Residual Scope
No deferred work remains for this implementation slice. Issue #8249 is reopened for this PR; this
is the immediate successor requested for the remaining
uv syncdiagnostic gaps.Reviewer Notes
uv cache sizeis absent from the executable path and that the later boundedduremains the sole cache-size traversal.
non-timeout tool failures remain visible.