Skip to content

test: keep optimized SVG guard probe compatible - #8442

Merged
ll7 merged 1 commit into
mainfrom
autopilot/fix-main-ci-optimized-20260904-cycle25
Sep 4, 2026
Merged

test: keep optimized SVG guard probe compatible#8442
ll7 merged 1 commit into
mainfrom
autopilot/fix-main-ci-optimized-20260904-cycle25

Conversation

@ll7

@ll7 ll7 commented Sep 4, 2026

Copy link
Copy Markdown
Owner

Summary

Repair the optimized-assert regression probe so it remains compatible with the
keyword-only geometry_contract argument now passed to SvgMapConverter.
The production SVG parser contract is unchanged; the test double previously
raised before reaching the intended unexpected-type guard, so the marker was
absent from the optimized subprocess output.

Related to #8441.

Scope and evidence boundary

  • Test-only CI repair; no runtime, planner, benchmark, metric, model, or research behavior changes.
  • The change accepts forwarded converter keyword arguments in the existing test double.
  • No compute job, benchmark campaign, generated artifact, or paper-facing claim was produced.

Exact current-base refresh

  • Current base: origin/main=c205767571edc4df71768216619ce13e18caa0f7.
  • Exact candidate head: eb9248d69fd1064c8adbe85efdc096053373a4b7.
  • Worktree: linked worktree fix-main-ci-optimized-20260904-cycle25.

Validation

  • tests/test_optimized_assert_guards.py: 5 passed.
  • SVG transform, generated replay adapter, scenario-loader, and optimized-guard coverage: 105 passed.
  • Ruff check and format check for tests/test_optimized_assert_guards.py: passed.
  • git diff --check: passed.
  • The original optimized subprocess failure reproduces before the one-line fix and passes after it.

Gate

compute: none

@coderabbitai

coderabbitai Bot commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Team

Run ID: de736287-1dfe-48bf-9102-6ba65d598d57


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added the review-bot-auto Managed label that routes code-bearing PRs to CodeRabbit. label Sep 4, 2026
@github-actions

github-actions Bot commented Sep 4, 2026

Copy link
Copy Markdown

🔍 PR Contract Check Summary

Overall Status: 🟢 PASSED

Check Status Description
1. Closes-discipline ✅ PASSED Demand Refs #N for epic issues
2. Closure declaration ✅ PASSED Require Closes/Refs for title issues
3. State-refresh-only ✅ PASSED Reject docs/context state updates
4. Evidence hygiene ✅ PASSED Checks markers and provenance fields
5. Evidence writer usage ✅ PASSED Require the shared marked writer path
6. Successor discipline ✅ PASSED Require successor statement on multi-PR issues
7. Worker-lane label ⚪ None Label PRs from cheap worker lane
8. Placeholder docstring ratchet ✅ PASSED Reject NEW TODO/empty docstrings in added diff lines

ℹ️ Info

  • No worker-lane provenance detected.

This check is mechanized. Please resolve any blockers to pass CI.

@ll7
ll7 force-pushed the autopilot/fix-main-ci-optimized-20260904-cycle25 branch from 29528d5 to eb9248d Compare September 4, 2026 18:06
@ll7

ll7 commented Sep 4, 2026

Copy link
Copy Markdown
Owner Author

Exact-head implementation review — approved

The test-only repair is correct and minimal. convert_map forwards the keyword-only
geometry_contract argument; the previous test double rejected it before the intended
unexpected-type guard ran. The strict mock now accepts exactly that keyword, so the optimized
subprocess exercises the existing production guard and preserves future unexpected-keyword
detection.

Local proof: 105 relevant tests passed, including all optimized-guard, SVG-transform,
generated-replay, and scenario-loader tests; Ruff, format, diff, and exact-base final readiness
passed with a clean linked worktree. The full hosted matrix, changed coverage, aggregate CI,
CodeQL, and contract checks are terminally green. No runtime, benchmark, research, domain,
legal, or compute claim is made.

Implementation-integrity confidence: 0.99. Safe to merge only through the guarded receipt below.

gate-verdict: accepted @ eb9248d69fd1064c8adbe85efdc096053373a4b7

pr-metadata: reconciled @ 428b195cd955183e22435bc8cb24723b9bc640c8fd4d34b104e5f9bb7eca3104

@ll7 ll7 added the merge-ready Verified by the PR gate and ready to merge label Sep 4, 2026
@ll7
ll7 merged commit 5f47662 into main Sep 4, 2026
34 of 36 checks passed
@ll7
ll7 deleted the autopilot/fix-main-ci-optimized-20260904-cycle25 branch September 4, 2026 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge-ready Verified by the PR gate and ready to merge review-bot-auto Managed label that routes code-bearing PRs to CodeRabbit.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant