Skip to content

fix(model): correct predictive registry cache paths #8438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ll7 merged 2 commits into from
Sep 4, 2026
+14 −2
Merged

fix(model): correct predictive registry cache paths #8438

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a895835
fix(model): correct predictive registry cache paths
ll7 Sep 4, 2026
9246b81
test(models): cover predictive registry cache pointers
ll7 Sep 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions model/registry.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -603,7 +603,7 @@ models:
- Generated by scripts/training/train_predictive_planner.py
- model_id: predictive_proxy_selected_v1
display_name: Predictive planner model (predictive_proxy_selected_v1)
local_path: output/tmp/predictive_planner/training/predictive_proxy_selected_v1/predictive_model.pt
local_path: output/model_cache/predictive_proxy_selected_v1/predictive_proxy_selected_v1-predictive_model.pt
config_path: null
commit: dfc4aea84e25cc83f9888c620286457bab3e1596
wandb_run_id: geedo1po
Expand Down Expand Up @@ -650,7 +650,7 @@ models:
- Generated by scripts/training/train_predictive_planner.py
- model_id: predictive_proxy_selected_v2_full
display_name: Predictive planner model (predictive_proxy_selected_v2_full)
local_path: output/tmp/predictive_planner/pipeline/predictive_br07_all_maps_randomized_full_20260305T123116Z/training/predictive_model.pt
local_path: output/model_cache/predictive_proxy_selected_v2_full/predictive_proxy_selected_v2_full-predictive_model.pt
config_path: configs/training/predictive/predictive_br07_all_maps_randomized_full.yaml
commit: cef93136b92ddca9b0c4436bc44049412461a2fd
wandb_run_id: u40parjb
Expand Down
12 changes: 12 additions & 0 deletions tests/unit/test_registry.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1000,3 +1000,15 @@ def test_upsert_registry_entry_requires_model_id(tmp_path: Path) -> None:
{"local_path": "output/model_cache/demo/model.zip"},
registry_path=tmp_path / "registry.yaml",
)


def test_predictive_proxy_registry_paths_match_release_assets() -> None:
"""Predictive proxy cache pointers should name their release assets exactly."""
registry_path = Path(__file__).resolve().parents[2] / "model" / "registry.yaml"
entries = registry.load_registry(registry_path)

for model_id in ("predictive_proxy_selected_v1", "predictive_proxy_selected_v2_full"):
entry = entries[model_id]
release = entry["github_release"]
assert Path(entry["local_path"]).parts[:3] == ("output", "model_cache", model_id)
assert Path(entry["local_path"]).name == release["asset_name"]
Loading