Speed Improvement through less looping - #83
Open
Skipants wants to merge 1 commit into
Open
Conversation
By flattening the loop and only doing YARD parsing once per different list of paths (model vs. controller) we see a significant speedup.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By flattening the loop and only doing YARD parsing once per different list of paths (model vs. controller) we see a significant speedup.
Here's the stats
swagger_yard:generateis our rake task that builds the spec and outputs the openapi file toartifacts/openapi.json.I use
wc artifacts/openapi.jsonto test that the generation is the same.