fix(byoc): V1 job-creds verify + restore type:byoc payment path#3980
Merged
eliteprox merged 1 commit intoJul 11, 2026
Merged
Conversation
Align staging orch with DMZ FlattenBYOCJob signing and accept explicit type:byoc on /generate-live-payment alongside the existing lv2v path. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
eliteprox
merged commit Jul 11, 2026
410aeeb
into
feat/byoc-per-cap-pricing-and-usage-labels
20 of 21 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
verifyJobCredsnow verifiesFlattenBYOCJobV1 signatures (matches DMZ/sign-byoc-jobsigning from4b0cf2fb/feat/byoc-v1-signing). Fixes deterministicCould not verify job credsafter payment succeeds.type:"byoc"on/generate-live-paymentalongside the existinglv2vpath. Derive BYOC capability constraint fromcapabilitiesprotobuf whencapabilitystring is omitted (c6d312f gateway shape). Per-cap pricing + compute-seconds billing unchanged forlv2v.TestResolveUsageLabels+TestGenerateLivePayment_ByocPerCapPricingfortype:byoc+ capabilities proto.Root causes fixed
type:byoc(invalid job type)RemoteType_BYOC; BYOC seconds billing pathCould not verify job credsFlattenBYOCJobverify injob_orchestrator.goTest plan
go test ./server/... -run 'TestResolveUsageLabels|TestGenerateLivePayment_ByocPerCapPricing'(CI)byoc-staging-1orch from this branchPOST /generate-live-paymentwithtype:byoc+ capabilities → 200 (notinvalid job type)submit_byoc_job→ sign-byoc-job 200 → payment 200 → orchprocess/request200byoc/<cap>notlive-video-to-video/unknownwrite_frames.py/ lv2v streaming path still passesDeploy order
feat/byoc-per-cap-pricing-and-usage-labels(or master after feat(signer): BYOC per-capability pricing + real capability/model usage labels #3972)type:byocMade with Cursor