feat(remote_signer): emit model_id in create_signed_ticket Kafka events#3947
Draft
eliteprox wants to merge 8 commits into
Draft
feat(remote_signer): emit model_id in create_signed_ticket Kafka events#3947eliteprox wants to merge 8 commits into
eliteprox wants to merge 8 commits into
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Collaborator
Author
|
This will go in |
eliteprox
force-pushed
the
feat/add-model-id-signer-kafka
branch
from
June 22, 2026 19:50
5c9ec54 to
e1e784f
Compare
eliteprox
force-pushed
the
feat/add-model-id-signer-kafka
branch
from
June 25, 2026 04:50
e1e784f to
f533245
Compare
eliteprox
force-pushed
the
feat/add-model-id-signer-kafka
branch
from
June 25, 2026 21:16
f533245 to
6bad183
Compare
eliteprox
added a commit
that referenced
this pull request
Jun 25, 2026
…ng tests - Implemented the ModelIDForCapability method in the Capabilities struct to return the constrained model ID for a given capability, ensuring deterministic results when multiple models are present. - Added unit tests for ModelIDForCapability to cover various scenarios, including nil receivers, no constraints, single constrained models, and handling of ambiguous model cases. - Updated the remote signer to include the model ID in the event payload for LiveVideoToVideo capabilities.
…al resolution - Modified the test for ModelIDForCapability to reflect that multiple models resolve to the lexicographically first ID instead of returning an empty string. - Adjusted the expected output in the test case to return "comfyui" for the Capability_LiveVideoToVideo capability.
- Updated the payment processing logic to include an optional `AuthID` in the `RemotePaymentState` and `authResponse` structures. - Modified the `doPaymentWithStateAndAuthID` function to accept and set the `AuthID` from the request header or callback response. - Added tests to verify the correct handling of `AuthID` in various scenarios, including fallback behavior and error handling when the `AuthID` changes unexpectedly. - Ensured that the `AuthID` is included in the response payload for better tracking and debugging.
Shared livepeerci/build:cache caused PR Docker tags (pr-3947, feat-add-model-id-signer-kafka) to point at an older livepeer binary while metadata listed the PR head SHA. Skip registry cache on pull_request builds and pass GIT_REVISION to bust the compile layer.
eliteprox
force-pushed
the
feat/add-model-id-signer-kafka
branch
from
July 8, 2026 19:41
82844a9 to
cfe860a
Compare
…ined model ID resolution - Introduced `CapabilityToPipeline` function to convert capabilities to their corresponding pipeline slugs, returning an empty string for unknown capabilities. - Implemented `ConstrainedPipelineModelID` method to return a deterministic pipeline/model ID pair based on per-capability constraints, ensuring lexicographical resolution when multiple capabilities are present. - Added unit tests for both new functions to validate their behavior under various scenarios, including handling of nil capabilities and multiple constraints. - Updated the remote signer to utilize the new constrained pipeline logic for improved payment processing.
…model-id-signer-kafka
Collaborator
Author
|
Clearinghouse is tracking the related work as non-blocking side-tracks (label
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Capabilities.ModelIDForCapability()to derive a model ID from per-capability constraintsmodel_idin the remote signercreate_signed_ticketKafka event for LV2V sessionsFixes OpenMeter/billing events showing
model_id: "unknown"when the gateway already sends model constraints in the capabilities protobuf on each/generate-live-paymentrequest.Test plan
go test -tags=mainnet,experimental ./core/ -run TestModelIDForCapabilitycreate_signed_ticketevents include realmodel_idfor LV2V