Fixes a race where await room.sid could hang even after the room SID was available in room._info.sid.#713
Open
xianshijing-lk wants to merge 1 commit into
Open
Conversation
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
cloudwebrtc
approved these changes
Jun 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Python binding previously resolved
_first_sid_futureonly fromroom_sid_changed. Under some event ordering, the SID could arrive through the initial connect result orroom_updatedfirst, leaving existingroom.sidwaitersunresolved.
Changes
_first_sid_futureso caller-sideasyncio.wait_for(room.sid, ...)timeouts do not cancel shared Room state._resolve_first_sid()helper.room_sid_changedroom_updatedmovedTesting
Run Theo's sid_repro.py