Add codec config to inbound and outbound SIP trunks.#1620
Open
dennwc wants to merge 2 commits into
Open
Conversation
🦋 Changeset detectedLatest commit: fa09be9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
hechen-eng
reviewed
Jun 12, 2026
hechen-eng
left a comment
hechen-eng
left a comment
Contributor
There was a problem hiding this comment.
The tests are failing due to Upgrade will create p.Media even if there is nothing to migrate 🤔
Maybe do
if p == nil || (p.Media == nil && p.MediaEncryption == SIPMediaEncryption_SIP_MEDIA_ENCRYPT_DISABLE) {
return
}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.