Add intensity to the feature widget - #482
Open
AnniekStok wants to merge 5 commits into
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #482 +/- ##
==========================================
+ Coverage 88.87% 88.96% +0.09%
==========================================
Files 59 59
Lines 5815 5883 +68
==========================================
+ Hits 5168 5234 +66
- Misses 647 649 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
cmalinmayor
requested changes
Sep 6, 2026
cmalinmayor
left a comment
Collaborator
There was a problem hiding this comment.
I think we can simplify this a bit - I'm not sure we need to worry about users incrementally updating the image layers associated with the Tracks. And, we can treat all the channels as one toggle, since computing the mean intensity of another channel is relatively cheap once we are calling regionprops regardless.
Proposed workflow:
- Setter that lets users assign image layers to the tracks. Usually only called once. Sets up the intensity feature with the proper number of channels. Lazy arrays are stored in the RegionpropsAnnotator, so we don't need to worry about renaming the layer
- Toggle button for the "image intensity" feature as whole, for all channels. Enables/disables the intensity feature.
- To change the intensity image(s), re-call the setter, reset the intensity feature, re-compute everything
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needs funkelab/funtracks#274