Add features to localize Welcome-Guide and Telemetry-Consent - #320
Open
juggernautjp wants to merge 4 commits into
Open
Add features to localize Welcome-Guide and Telemetry-Consent#320juggernautjp wants to merge 4 commits into
juggernautjp wants to merge 4 commits into
Conversation
This fix enable to localize Welcome-Guide and Telemetry-Consent views, and fix some minor bug of Welcome view.
juggernautjp
requested review from
Anonym0uz,
liuderchi,
nerhis,
preco21 and
stsewd
as code owners
June 18, 2021 11:06
liuderchi
reviewed
Jul 3, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requirements for Contributing a Bug Fix
This fix enable
atom-i18nto localize "Welcome Guide" and "Telemetry Consent" views.Identify the Bug
atom-i18ncan not localize both "Welcome Guide" and "Telemetry Consent" views.Those bugs are opened as the Issue #319.
Description of the Change
add/localize-welcome-viewsAlternate Designs
None
Possible Drawbacks
User might not be be able to change
telemetry consentsettings.Verification Process
npm run validation -- --locale.atom-i18n, by manually changing locale.Release Notes