Repository navigation
Fix TypeScript validation and stale requirement references - #32
Merged
Merged
Conversation
Attribute links resolve to attribute nodes. The grammar type now includes that target so the project typecheck accepts the link tests.
Check reported missing export, index, startup, and context-centre names. Each link now names an idea that the target file declares.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GitHub CI on
mainstopped inpnpm run build:tsc.packages/language/test/linking.test.tsdid not typecheck: an attribute link is anAttributeat runtime, but the grammar typed the second name only as an idea declaration. Captureddocumentbindings in two tests were also possibly undefined.reqlan check --skip-gitignored-targetsthen reported eight missing idea names.QualifiedIdeaTargetis an idea declaration or an attribute. CodeLens keeps idea declarations only.export_JSON,export_csv,index_ideas,index_technology,extension_startup_reliability, andcontext_footprint.Tests
pnpm --filter ./packages/language run test— 42 files, 479 tests passed.pnpm run build:tsc— passed.node packages/cli/bin/cli.js check --skip-gitignored-targets—No issues.The default check without
--skip-gitignored-targetsstill reports gitignored onboarding media and.cursorpaths. CI passes that flag.