[lib][console] Remove redundant NULL checks before free#518
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR simplifies the command_loop() cleanup path in LK’s console library by removing redundant NULL checks before calling free() in the no_mem_error: label.
Changes:
- Replace
if (ptr) free(ptr);patterns with unconditionalfree(outbuf); free(args);in theno_mem_errorcleanup path. - Align the error-path cleanup style with the already-unconditional cleanup used on the normal return path in the same function.
travisg
approved these changes
Jul 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove redundant
NULLchecks beforefree()inlib/console/console.c.In the
no_mem_errorpath ofcommand_loop(),free(outbuf)andfree(args)are sufficient becausefree(NULL)is defined as a no-op in C. This simplifies the cleanup path without changing behavior.Testing
-
make qemu-virt-arm64-test